Calendar: Pass custom formatters to react-calendar
#11745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 20, 2022
swissspidy
added
the
Type: Enhancement
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
The words AM / PM are not translated. Whether you see this setting or not depends on the time format you've set under Settings -> General If you choose a setting like If you choose This is existing and expected behavior that is not changed here.
Check the PR description:
This is blocked by wojtekmaj/react-calendar#620 |
|
Size Change: +73 B (0%) Total Size: 2.64 MB ℹ️ View Unchanged
|
interesting. I wonder what is happening in hindi then. |
|
Looks like our translators translated it into Hindi, see https://translate.wordpress.org/projects/wp-plugins/web-stories/stable/hi/default/?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=10535771&filters%5Btranslation_id%5D=84343736 Not an expert there so I trust their decision. |
|
Plugin builds for 94598f6 are ready 🛎️!
|
spacedmonkey
approved these changes
Jun 27, 2022
timarney
approved these changes
Jun 27, 2022
|
@spacedmonkey @swissspidy hey guys! When I change to the language to Portuguese or French, on Settings > General, I see some weird week days, such as Game, Life, Home, Sec, What, Who... |
|
@felipebochehin87 I don't see this:
Did you accidentally translate the site using Google Translate? That would explain this. Try disabling Google Translate or use another browser briefly. |
|
Oh that explains the "Game", "Jeu"... Makes sense. Works for me too. Thanks! Approving this PR. |
swissspidy
added a commit
that referenced
this pull request
Sep 19, 2022
Ensures weekdays are properly translated in calendar. See #11745
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
Passes custom date formatters to
react-calendarto ensure dates are properly localized according to the WPRelevant Technical Choices
To-do
Maybe make the
F Yformat filterable (wrap in__())User-facing changes
Calendar should be translated
Testing Instructions
This PR can be tested by following these steps:
Known limitation
When you hover over the weekday, the day is not translated yet.
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #11734